Increase file cache chunk size from 16 KB to 1 MB#1388
Merged
Conversation
veluca93
force-pushed
the
filecacher-large-files
branch
from
June 7, 2025 22:27
8228ddb to
69f4818
Compare
Member
|
I think it would be nice to benchmark this (with different amounts of simulated network latency between cms and the database), but i'm pretty sure using 1MB as the default won't really break anything. I do think that making it too big might make things slower in some cases, but maybe 1MB isn't noticeable yet. |
Contributor
Author
|
I'm also fairly sure this will be fine at 1mb - and on low latency networks I imagine it won't cause problems. On high latency networks, I think this was tested enough at IOI :D |
To improve performance when connecting to worker instances over high latency network
veluca93
force-pushed
the
filecacher-large-files
branch
from
June 8, 2025 17:01
69f4818 to
399c75e
Compare
prandla
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve performance when connecting to worker instances over high latency network
Fixes #1368